Why the array output only the 41946123 number instead of elements in order? What's wrong?

Question

#include <stdio.h>
 
int main()
{
    int i, x, num, sum;
    printf ("Enter the size of the array: \n");  scanf("%d", &num);
    printf ("Enter the 1st element: \n");          scanf("%d", &x);
    int A[num];
    A[0]=x; A[1]=x + 10;
   for(i=2; i<num; i++);
    {  
     A[i]=A[i-2]+A[i-1];
    }
     printf("%d", A[num]);
   getchar();       
  return 0;
}

Answer 1

You need first to get rid of the semicolon at the end of for(int i .....) line. if you put semicolons right after for lines, it will loop but it is not going to show any outputs

Secondly, you can't print array's element at one time, you need a loop to go through all elements in your array

Instead of printf("%d", A[num]) use this

for (int i = 0; i<num;i++) 

{

    printf("%d ", A[i]);

}

Comments

Yeah, thx man. It was the main problem of solving the task.

---

how can i make it in Java platforrm ?

Answer 2

When you define an array suppose A[int num] then the elements get the indices from 0 to num-1

when you are printing it you have written A[num] that is not right. The last element of the array will have the index num-1 so try using A[num-1] for printing the last element.

if you want to print all the elements try using loops.

Answer 3

Your array A has num elements in it. Indexing in most programming languages is 0-based. So when you try to access A[num] you're indexing outside of the array as the last element's index is num-1. (If this is not clear, try it with a small number, e.g. 3 and index the elements one by one starting from 0.)

Answer 4

The for loop 

for(i=2; i<num; i++);

has an extra semi-colon at the end. This will only increment i until the condition is met and only the elements A[0] and A[1] are initialized to a valid value. 

Also the printf() function 

printf("%d", A[num]);

with the A[num] is printing out A[5] which the other Answer by Peter Minarik points out needs to be A[num-1] since we are using zero-based arrays. To print out each element we could us a separate for loop like:

_{for(i=0; i<num; i++); { printf("%d ", A[i]); }}

Comments

Good point! I missed that there was a semicolon at the end of the for loop.

However, you made the same mistake:

for(i=0; i<num; i++); { printf("%d ", A[i]); }

contains an unwanted semicolon after the for statement.

Answer 5

 A[num-1] is last